chore: add additional metadata to cargo.toml and pin to rust to 1.88.0 #331
+56
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abhi-airspace-intelligence
changed the title
|
Lint failures seem to be related to this change in Clippy 1.89, which CI was previously running at. I can instead just bump the CI jobs to stable/1.89, or address the lints directly? rust-lang/rust-clippy#15287 |
abhi-airspace-intelligence
force-pushed
the
abhi/cargo-toml-maintenance
branch
from
a290eee to
1d3571f
Compare
iambriccardo
approved these changes
Sep 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
This pins
rust-versionto 1.88 and updates CI/CD to target it. At my company, the internal tooling we're developing around etl failed to compile due to our internal base images being based on 1.87. This could've been caught ifrust-versionwas specified, as cargo with edition 2024 warns if a package is incompatible based on their stated MSRV.Additionally, tools like
cargo-denyfail to work as none of the licenses were specified, so this updates that. I did some house cleaning and added additional metadata to the cargo.toml as well (such as repository information, a link to the docs, etc).What is the current behavior?
Fixes #322, the license field was added to fix cargo-deny issues from internal tooling
What is the new behavior?
Not much, edition=2024 already implies resolver 3, so moving it to resolver 2 is cosmetic.
Additional context